Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes phpunit-workflow #2672

Merged
merged 1 commit into from
Nov 1, 2022
Merged

Fixes phpunit-workflow #2672

merged 1 commit into from
Nov 1, 2022

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Oct 31, 2022

Description (*)

Remove --strict validation from phpunit test.

Fixed Issues (if relevant)

https://github.com/OpenMage/magento-lts/actions/runs/3364517392/jobs/5578955941

Run composer validate --strict
./composer.json is valid, but with a few warnings
See https://getcomposer.org/doc/04-schema.md for details on the schema
# General warnings
- require.phpunit/phpunit : unbound version constraints (*) should be avoided
- require.n98/magerun : unbound version constraints (*) should be avoided
Error: Process completed with exit code 1.

Questions or comments

@Flyingmana can you change this?

https://github.com/OpenMage/Testfield/blob/4c0f103c40ed908262d4f782db5f6da0aa52b3ae/composer.json#L22-L23

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@fballiano fballiano merged commit 8774526 into OpenMage:1.9.4.x Nov 1, 2022
@sreichel sreichel deleted the hotfix/phpunit-workflow branch November 1, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants